Skip to content

update oracledb to v4 - #186

Merged
nabdelgadir merged 1 commit into
masterfrom
update-oracle-v4
Jul 29, 2019
Merged

update oracledb to v4#186
nabdelgadir merged 1 commit into
masterfrom
update-oracle-v4

Conversation

@nabdelgadir

@nabdelgadir nabdelgadir commented Jul 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

update oracledb to v4

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

@dhmlau dhmlau mentioned this pull request Jul 26, 2019
Closed
@nabdelgadir

nabdelgadir commented Jul 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

New failure (for all node versions):

1) lazyConnect
        should report connection error (lazyConnect = false):
      Uncaught AssertionError: expected 'ORA-24415: Missing or null username.' to contain 'TNS'

Other CI failures are tracked in #183

@nabdelgadir nabdelgadir self-assigned this Jul 29, 2019
@nabdelgadir
nabdelgadir marked this pull request as ready for review July 29, 2019 13:40
@nabdelgadir

nabdelgadir commented Jul 29, 2019

Copy link
Copy Markdown
Contributor Author

The lazyConnect failure was fixed with this line but the rest of the CI failures aren't related to this PR and are already tracked in #183.

@emonddr
emonddr self-requested a review July 29, 2019 14:00
emonddr
emonddr approved these changes Jul 29, 2019
View reviewed changes

@emonddr emonddr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

agnes512
agnes512 approved these changes Jul 29, 2019
View reviewed changes

@agnes512 agnes512 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lazyConnect failure was fixed with this line but the rest of the CI failures aren't related to this PR and are already tracked in #183.

Oh it makes sense now. I was wondering if updated to v4 causes new failure

@nabdelgadir
nabdelgadir merged commit ce8442c into master Jul 29, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the update-oracle-v4 branch July 29, 2019 14:15
@dhmlau dhmlau mentioned this pull request Jul 29, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b-admike b-admike Awaiting requested review from b-admike
@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau is a code owner
@jannyHou jannyHou Awaiting requested review from jannyHou
2 more reviewers
@emonddr emonddr emonddr approved these changes
@agnes512 agnes512 agnes512 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@nabdelgadir nabdelgadir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nabdelgadir @emonddr @agnes512