Skip to content

Globalize postgresql#152

Merged
jannyHou merged 2 commits intomasterfrom
globalization
Jul 28, 2016
Merged

Globalize postgresql#152
jannyHou merged 2 commits intomasterfrom
globalization

Conversation

@jannyHou
Copy link
Copy Markdown
Contributor

@jannyHou jannyHou commented Jul 25, 2016 •
edited
Loading

@jannyHou jannyHou self-assigned this Jul 25, 2016
@0candy 0candy mentioned this pull request Jul 25, 2016
Closed
63 tasks
@jannyHou jannyHou changed the title Globalize discover.js Globalize postgresql Jul 26, 2016
@rmg
Copy link
Copy Markdown
Contributor

rmg commented Jul 27, 2016

@slnode test please

@jannyHou jannyHou force-pushed the globalization branch 2 times, most recently from b40321a to 4abba63 Compare July 28, 2016 15:30
@jannyHou
Copy link
Copy Markdown
Contributor Author

jannyHou commented Jul 28, 2016

@Amir-61 @loay A small globalization pr :) PTAL
Thanks.

loay
loay reviewed Jul 28, 2016
View reviewed changes
Comment thread lib/migration.js Outdated
});
} else {
throw Error('Index keys definition appears to be invalid: ', keys);
throw Error(g.f('Index keys definition appears to be invalid: %s', keys));
Copy link
Copy Markdown
Contributor

@loay loay Jul 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be: {{keys}} or even {{ Index keys}}

@jannyHou
Copy link
Copy Markdown
Contributor Author

jannyHou commented Jul 28, 2016

@loay Thank you applied 👍

@loay
Copy link
Copy Markdown
Contributor

loay commented Jul 28, 2016

LGTM for code.
PTAL at CI failures.

@jannyHou
Copy link
Copy Markdown
Contributor Author

jannyHou commented Jul 28, 2016

@slnode test please

@jannyHou
Copy link
Copy Markdown
Contributor Author

jannyHou commented Jul 28, 2016

CI on stable platforms are all green: http://ci.strongloop.com/job/loopback-connector-postgresql/1032/

nvm platforms are failing due to role jenkins does not exist. Should be a config problem.

1) Autocreate schema if not exists "before all" hook:
     Uncaught error: role "jenkins" does not exist
      at Connection.parseE (node_modules/pg/lib/connection.js:551:11)
      at Connection.parseMessage (node_modules/pg/lib/connection.js:378:17)
      at Socket.<anonymous> (node_modules/pg/lib/connection.js:117:22)
      at Socket.<anonymous> (_stream_readable.js:765:14)
      at emitReadable_ (_stream_readable.js:427:10)
      at emitReadable (_stream_readable.js:423:5)
      at readableAddChunk (_stream_readable.js:166:9)
      at Socket.Readable.push (_stream_readable.js:128:10)
      at TCP.onread (net.js:529:21)

  2) Autocreate schema if not exists Uncaught error outside test suite:
     Uncaught TypeError: Cannot call method 'currentRetry' of undefined


  3) Autocreate schema if not exists Uncaught error outside test suite:
     Uncaught error: role "jenkins" does not exist
      at Connection.parseE (node_modules/pg/lib/connection.js:551:11)
      at Connection.parseMessage (node_modules/pg/lib/connection.js:378:17)
      at Socket.<anonymous> (node_modules/pg/lib/connection.js:117:22)
      at Socket.<anonymous> (_stream_readable.js:765:14)
      at emitReadable_ (_stream_readable.js:427:10)
      at emitReadable (_stream_readable.js:423:5)
      at readableAddChunk (_stream_readable.js:166:9)
      at Socket.Readable.push (_stream_readable.js:128:10)
      at TCP.onread (net.js:529:21)

@jannyHou jannyHou merged commit dcf5d8c into master Jul 28, 2016
@jannyHou jannyHou removed the #review label Jul 28, 2016
@0candy 0candy deleted the globalization branch August 4, 2016 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jannyHou jannyHou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jannyHou @rmg @loay