fix syntax issue causing failure on older versions of nodeJS#156
fix syntax issue causing failure on older versions of nodeJS#156brettcomardelle wants to merge 1 commit into
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
@brettcomardelle, thanks for your PR. Your changes LGTM. Could you please fix the commit linter error? Thanks. |
|
Here is the instruction to amend git message: https://help.github.com/en/github/committing-changes-to-your-project/changing-a-commit-message See our commit message guideline: https://loopback.io/doc/en/contrib/git-commit-messages.html. |
4e8bf1b to
3bd97b8
Compare
|
I have amended the commit message for you, let's wait for CI results before landing. |
|
@slnode ok to test |
|
The builds are failing on linting, because our eslint config is enforcing trailing commas. I did a bit of investigation and have few comments: Node.js 8.0 and newer support trailing commas in function arguments. Here is an example to try: function x(
a,
) {
console.log('ok', a);
}
x(1);We don't support Node.js 7.x, it has reached end of life way too long time ago. In that light, I am closing this pull request as rejected. |
Description
Running the connector in node v7 and v8 failed due to the trailing commas. Later versions of nodeJS would ignore the syntax issue.
Related issues
Checklist
guide