Notify find 2.x - #1061
Merged
Merged
Conversation
Contributor
Author
|
@slnode test please |
Member
|
FWIW, here is the original pull request against the master branch: #898 |
Member
|
The patch LGTM, |
Amir-61
force-pushed
the
notify_find_2.x
branch
from
August 23, 2016 23:01
9108fc5 to
a1a9bac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notify find 2.x
We already implemented
notifyforfindon master branch; however the implementation offindis very different from the one on2.x, hence a simple cherry-pick was not going to work; this patch implementsnotifyfor2.x