Skip to content

fix: update typescript declarations #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b-admike merged 1 commit into from
Jan 31, 2019
Merged

fix: update typescript declarations #1654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions types/connector.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export interface Connector {
disconnect(callback?: Callback): PromiseOrVoid; // Disconnect from the underlying system
ping(callback?: Callback): PromiseOrVoid; // Ping the underlying system
execute?(...args: any[]): Promise<any>;
[property: string]: any; // Other properties that vary by connectors
Comment thread
bajtos marked this conversation as resolved.
}

/**
Expand Down
2 changes: 1 addition & 1 deletion types/persisted-model.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ export declare class PersistedModel extends ModelBase {
data: PersistedData,
options?: Options,
callback?: Callback<PersistedModel>,
): PromiseOrVoid<PersistedModel>;
): PromiseOrVoid<[PersistedModel, boolean]>;

@bajtos bajtos Nov 5, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


/**
* Check whether a model instance exists in database.
Expand Down