Skip to content

Add support for Node.js 12.x #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajtos merged 1 commit into from
Apr 30, 2019
Merged

Add support for Node.js 12.x #1728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@ language: node_js
node_js:
- "8"
- "10"
- "12"

after_success: npm run coverage
7 changes: 7 additions & 0 deletions lib/date-string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,10 @@ DateString.prototype.inspect = function(depth, options) {
_date: this._date,
});
};

if (inspect.custom) {
// Node.js 12+ no longer recognizes "inspect" method,
// it uses "inspect.custom" symbol as the key instead
// TODO(semver-major) always use the symbol key only (requires Node.js 8+).
DateString.prototype[inspect.custom] = DateString.prototype.inspect;
}
2 changes: 2 additions & 0 deletions lib/model-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,8 @@ ModelUtils._coerce = function(where, options) {
self._coerce(clauses[k], options);
}

where[p] = clauses;

@bajtos bajtos Apr 29, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of weird. Before my change, the block "handle logical operators" did not apply updates made by coerceArray to the original where[p] value. As a result, array-like object {1: {field: 'value'}} was not converted into an array [{field: 'value'}]. I am not sure why this was not caught earlier and surfaced only with Node.js 12. Is it perhaps a change in how deep-equality checks work on the new Node version? IDK.

@bajtos bajtos Apr 29, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the tests that are failing without my fix:

https://github.com/strongloop/loopback-datasource-juggler/blob/47addd943adfd7ace37cd52d2d4dcbd04ee7c0d8/test/loopback-dl.test.js#L1498-L1503


continue;
}
let DataType = props[p] && props[p].type;
Expand Down
7 changes: 7 additions & 0 deletions lib/model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,13 @@ ModelBaseClass.prototype.inspect = function(depth) {
});
};

if (util.inspect.custom) {
// Node.js 12+ no longer recognizes "inspect" method,
// it uses "inspect.custom" symbol as the key instead
// TODO(semver-major) always use the symbol key only (requires Node.js 8+).
ModelBaseClass.prototype[util.inspect.custom] = ModelBaseClass.prototype.inspect;
}

/**
*
* @param {String} anotherClass could be string or class. Name of the class or the class itself
Expand Down