Skip to content

Add support for Node.js 12.x [3.x]#1729

Merged
bajtos merged 1 commit into
3.xfrom
chore/add-node-12-3x
May 2, 2019
Merged

Add support for Node.js 12.x [3.x]#1729
bajtos merged 1 commit into
3.xfrom
chore/add-node-12-3x

Conversation

@bajtos

@bajtos bajtos commented Apr 30, 2019

Copy link
Copy Markdown
Member

Back-port #1728:

  • Fix code to pass all tests on Node.js 12
  • Add Node.js 12 to the list of Travis CI platforms

- Fix code to pass all tests on Node.js 12
- Add Node.js 12 to the list of Travis CI platforms
@bajtos
bajtos changed the base branch from master to 3.x April 30, 2019 07:17
@bajtos bajtos changed the title Chore/add node 12 3x Add support for Node.js 12.x Apr 30, 2019
@bajtos bajtos self-assigned this Apr 30, 2019
@bajtos
bajtos requested a review from raymondfeng April 30, 2019 07:17
@bajtos bajtos changed the title Add support for Node.js 12.x Add support for Node.js 12.x [2.x] Apr 30, 2019
@hacksparrow
hacksparrow self-requested a review May 2, 2019 07:12

@hacksparrow hacksparrow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@bajtos bajtos changed the title Add support for Node.js 12.x [2.x] Add support for Node.js 12.x [3.x] May 2, 2019
@bajtos
bajtos merged commit e27efd9 into 3.x May 2, 2019
@bajtos
bajtos deleted the chore/add-node-12-3x branch May 2, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants