Skip to content

Fix autoupdate queueing automigrate instead#1762

Merged
dhmlau merged 1 commit into
loopbackio:masterfrom
darthmaim:patch-1
Jul 25, 2019
Merged

Fix autoupdate queueing automigrate instead#1762
dhmlau merged 1 commit into
loopbackio:masterfrom
darthmaim:patch-1

Conversation

@darthmaim

Copy link
Copy Markdown
Contributor

Description

The autoupdate method was queueing automigrate. This bug was introduced in 40286fc.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

@slnode

slnode commented Jul 24, 2019

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@dhmlau dhmlau added the community-contribution Patches contributed by community label Jul 24, 2019
@dhmlau

dhmlau commented Jul 25, 2019

Copy link
Copy Markdown
Member

@slnode test please

@dhmlau dhmlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darthmaim, thanks for your PR. Would like to get at least one more review before landing. Thanks.

@dhmlau
dhmlau merged commit dd7167b into loopbackio:master Jul 25, 2019
@dhmlau

dhmlau commented Jul 25, 2019

Copy link
Copy Markdown
Member

@darthmaim, your PR has landed! 🎉

@darthmaim
darthmaim deleted the patch-1 branch July 26, 2019 06:51
bajtos added a commit that referenced this pull request Jul 26, 2019
 * Fix coercion of PK value in `replaceById` method (Miroslav Bajtoš)
 * Fix autoupdate queueing automigrate instead (#1762) (darthmaim)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Patches contributed by community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Autoupdate" actually drops tables instead of altering them

4 participants