types: make DataSource.stop compatible with LB4#1838
Merged
Conversation
Change the return value of `DataSource.stop()` from `Promise<void>` to `void | PromiseLike<void>` to avoid breaking existing LoopBack 4 applications, where DataSource subclasses are scaffolded with `stop(): ValueOrPromise<void>`. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
bajtos
requested review from
dhmlau,
emonddr,
jannyHou and
zbarbuto
as code owners
April 28, 2020 06:31
This was referenced Apr 28, 2020
raymondfeng
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #1835.
Change the return value of
DataSource.stop()fromPromise<void>tovoid | PromiseLike<void>to avoid breaking existing LoopBack 4 applications, where DataSource subclasses are scaffolded withstop(): ValueOrPromise<void>.Before the change, build of loopback-next was failing with the following errors (see loopbackio/loopback-next#5261)
https://travis-ci.com/github/strongloop/loopback-next/jobs/323793285
I have manually verified that the new typings are fixing loopback-next build:
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine