Skip to content

Validation only occurs at root level when there are nested Models #136#491

Closed
komarik0 wants to merge 3 commits into
loopbackio:masterfrom
komarik0:nestedValidation
Closed

Validation only occurs at root level when there are nested Models #136#491
komarik0 wants to merge 3 commits into
loopbackio:masterfrom
komarik0:nestedValidation

Conversation

@komarik0

@komarik0 komarik0 commented Mar 6, 2015

Copy link
Copy Markdown

No description provided.

@slnode

slnode commented Mar 6, 2015

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@raymondfeng

Copy link
Copy Markdown
Contributor

@komarik0 Thank you for the patch. Can you add a test case?

fix: using inst[attr] instead of data[attr]
adding tests
@komarik0

Copy link
Copy Markdown
Author

@raymondfeng, done. tests were added.

@bajtos

bajtos commented Mar 20, 2015

Copy link
Copy Markdown
Member

Isn't this the same bug I pointed out in #516 (comment)? IIUC, the validations are triggered when you e.g. add a new embedded model instance, but they are not triggered when you update an existing instance.

I think @fabien should review this patch too, he is the author of embedded relations.

@raymondfeng

Copy link
Copy Markdown
Contributor

@fabien ping

@bajtos

bajtos commented Sep 6, 2016

Copy link
Copy Markdown
Member

@komarik0 sorry for the long delay. Are you still interested in getting this patch landed?

@slnode

slnode commented Sep 6, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode

slnode commented Sep 6, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

2 similar comments
@slnode

slnode commented Sep 6, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@slnode

slnode commented Sep 6, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@bajtos

bajtos commented Sep 6, 2016

Copy link
Copy Markdown
Member

@slnode ok to test

@bajtos

bajtos commented Oct 6, 2016

Copy link
Copy Markdown
Member

I am closing this patch as abandoned. Feel free to reopen if you get time to address our comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants