Validation only occurs at root level when there are nested Models #136#491
Validation only occurs at root level when there are nested Models #136#491komarik0 wants to merge 3 commits into
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
62fee33 to
6785d6c
Compare
6785d6c to
b9d7b2c
Compare
|
@komarik0 Thank you for the patch. Can you add a test case? |
fix: using inst[attr] instead of data[attr] adding tests
|
@raymondfeng, done. tests were added. |
|
Isn't this the same bug I pointed out in #516 (comment)? IIUC, the validations are triggered when you e.g. add a new embedded model instance, but they are not triggered when you update an existing instance. I think @fabien should review this patch too, he is the author of embedded relations. |
|
@fabien ping |
|
@komarik0 sorry for the long delay. Are you still interested in getting this patch landed? |
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@slnode ok to test |
|
I am closing this patch as abandoned. Feel free to reopen if you get time to address our comments above. |
No description provided.