Ensure boolean value for isNewInstance#532
Closed
rmg wants to merge 1 commit into
Closed
Conversation
The tests are testing for true/false, not truthy/falsy, so the value should be coerced to match.
Member
|
There are three valid values: true, false and undefined meaning either it's not possible to tell or that the connector does not provide the value yet. Which is the case of the mongodb connector I believe? /cc @superkhau |
Member
|
@rmg here is the algorithm I need to preserve:
|
Contributor
Author
|
I made this change to match the test suite. I guess it's the test suite that needs updating instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests are testing for true/false, not truthy/falsy, so the value
should be coerced to match.
@bajtos I found this while tinkering with loopbackio/loopback-connector-mongodb#116