changes to dao.js and memory.js to add a new method on Upsert based on non-primary key - #995
Closed
mountain1234585 wants to merge 10 commits into
Closed
changes to dao.js and memory.js to add a new method on Upsert based on non-primary key#995mountain1234585 wants to merge 10 commits into
mountain1234585 wants to merge 10 commits into
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
| }); | ||
| }; | ||
|
|
||
| Memory.prototype.upsertWithWhere = function(model,data,options,callback){ |
Contributor
There was a problem hiding this comment.
The method signature is not correct. The where argument is missing.
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
dao.js handles the logic.
| self.create(data, function (err, results) { | ||
|
|
||
| if (err) | ||
| callback(err); |
Contributor
There was a problem hiding this comment.
We always return err in one line:
if (err) callback(err);
Contributor
|
@mountain1234585 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Raymond,
Kindly review the basic changes done to loopback-datasource-juggler lib/dao.js and lib/connectors/memory.js to include a new method called "upsertWithWhere" based on non-primary key.
1)This method leverages the existing methods, find, create, findById and updateAttributes.
2)I have not added notifyObserversOf like in other methods , since this method calls them internally.
3)Once you review the code changes, we will add the unit tests as well.
4) I have tested the operation manually by creating an application, memory db datasource and persisted model in case of create and update scenarios.
Thanks,
Sonali Samantaray