Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/rest/src/router/routing-table.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,13 @@ export class RoutingTable {
const paths: PathObject = {};

for (const route of this._router.list()) {
if (!paths[route.path]) {
paths[route.path] = {};
}
if (!route.spec['x-internal']) {
if (!paths[route.path]) {
paths[route.path] = {};
}

paths[route.path][route.verb] = route.spec;
paths[route.path][route.verb] = route.spec;
}
}

return paths;
Expand All @@ -187,6 +189,10 @@ export class RoutingTable {
}
}

export interface LB4OperationObject extends OperationObject {
readonly 'x-internal'?: boolean;
}

/**
* An entry in the routing table
*/
Expand All @@ -202,7 +208,7 @@ export interface RouteEntry {
/**
* OpenAPI operation spec
*/
readonly spec: OperationObject;
readonly spec: LB4OperationObject;

/**
* Update bindings for the request context
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,29 @@ describe('RestServer.getApiSpec()', () => {
});
});

it('ignores routes marked as "x-internal" via app.route(route)', () => {
function greet() {}
function meet() {}
server.route(
new Route(
'get',
'/greet',
{'x-internal': true, responses: {}, spec: {}},
greet,
),
);
server.route(new Route('get', '/meet', {responses: {}, spec: {}}, meet));
const spec = server.getApiSpec();
expect(spec.paths).to.eql({
'/meet': {
get: {
responses: {},
spec: {},
},
},
});
});

it('returns routes registered via app.route(..., Controller, method)', () => {
class MyController {
greet() {}
Expand Down Expand Up @@ -116,6 +139,46 @@ describe('RestServer.getApiSpec()', () => {
});
});

it('ignores routes marked as "x-internal" via app.route(..., Controller, method)', () => {
class GreetController {
greet() {}
}

class MeetController {
meet() {}
}

server.route(
'get',
'/greet',
{'x-internal': true, responses: {}},
GreetController,
createControllerFactoryForClass(GreetController),
'greet',
);

server.route(
'get',
'/meet',
{responses: {}},
MeetController,
createControllerFactoryForClass(MeetController),
'meet',
);

const spec = server.getApiSpec();
expect(spec.paths).to.eql({
'/meet': {
get: {
responses: {},
'x-controller-name': 'MeetController',
'x-operation-name': 'meet',
tags: ['MeetController'],
},
},
});
});

it('honors tags in the operation spec', () => {
class MyController {
@get('/greet', {responses: {'200': {description: ''}}, tags: ['MyTag']})
Expand Down