Skip to content

chore: update dependency change-case to v4#4233

Merged
raymondfeng merged 2 commits into
masterfrom
renovate/change-case-4.x
Jan 10, 2020
Merged

chore: update dependency change-case to v4#4233
raymondfeng merged 2 commits into
masterfrom
renovate/change-case-4.x

Conversation

@renovate

@renovate renovate Bot commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
change-case dependencies major ^3.1.0 -> ^4.1.1

Release Notes

blakeembrey/change-case

v4.1.1

Compare Source

v4.1.0

Compare Source

v4.0.1

Compare Source

v4.0.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate
renovate Bot requested review from bajtos and raymondfeng as code owners December 1, 2019 07:23
@bajtos

bajtos commented Dec 2, 2019

Copy link
Copy Markdown
Member

I think this is the relevant changelog entry: https://github.com/blakeembrey/change-case/releases/tag/change-case%404.0.0

  • Reduced exported functions to ten (10) *-case libraries that convert back and forth between cases
    • All other change-case packages are available separately
  • Directly export * from for all case libraries, no renames or aliases

@bajtos

bajtos commented Dec 2, 2019

Copy link
Copy Markdown
Member
  1) lb4 controller
391       basic controller
392         scaffolds correct file with input:
393     TypeError: Cannot read property 'replace' of undefined
394      at Object.noCase (packages/cli/node_modules/no-case/src/index.ts:28:6)
395      at Object.pascalCase (packages/cli/node_modules/pascal-case/src/index.ts:15:10)
396      at Object.camelCase (packages/cli/node_modules/camel-case/src/index.ts:11:10)
397      at ControllerGenerator.scaffold (packages/cli/generators/controller/index.js:16:563)
398      at Object.<anonymous> (packages/cli/node_modules/yeoman-generator/lib/index.js:402:23)
399      at /home/travis/build/strongloop/loopback-next/packages/cli/node_modules/run-async/index.js:25:25
400      at new Promise (<anonymous>)
401      at /home/travis/build/strongloop/loopback-next/packages/cli/node_modules/run-async/index.js:24:19
402      at /home/travis/build/strongloop/loopback-next/packages/cli/node_modules/yeoman-generator/lib/index.js:403:9
403      at processImmediate (internal/timers.js:439:21)

I opened an issue blakeembrey/change-case#69. I think this path is triggered by the following line:

https://github.com/strongloop/loopback-next/blob/151dfd81bf58dab4c459e9a07c7c1e0acf472df0/packages/cli/generators/controller/index.js#L230

Maybe the artifact name is not defined and we need to change our code to handle that situation?

  3) Utils
421       toClassName
422         should remove underscores
423           if the class name contains more than one underscores:
424
425      AssertionError: expected 'FooBar' to be 'FooBAr'
426      + expected - actual
427
428      -FooBar
429      +FooBAr
430      
431      at Assertion.fail (packages/testlab/node_modules/should/as-function.js:275:17)
432      at Assertion.value (packages/testlab/node_modules/should/as-function.js:356:19)
433      at Context.<anonymous> (packages/cli/test/unit/utils.unit.js:164:45)
434      at processImmediate (internal/timers.js:439:21)
435
436  4) Utils
437       toClassName
438         should remove underscores
439           if the class name contains underscores and digits:
440
441      AssertionError: expected 'Foo1Bar' to be 'Foo1BAr'
442      + expected - actual
443
444      -Foo1Bar
445      +Foo1BAr
446      
447      at Assertion.fail (packages/testlab/node_modules/should/as-function.js:275:17)
448      at Assertion.value (packages/testlab/node_modules/should/as-function.js:356:19)
449      at Context.<anonymous> (packages/cli/test/unit/utils.unit.js:164:45)
450      at processImmediate (internal/timers.js:439:21)

toClassName is implemented as follows:

 return pascalCase(camelCase(name));

The tricky and weird part is that pascalCase is imported from change-case but camelCase is imported from lodash 🤔

@renovate
renovate Bot force-pushed the renovate/change-case-4.x branch from ccd2b46 to 31d5f0f Compare December 3, 2019 05:47
@renovate
renovate Bot force-pushed the renovate/change-case-4.x branch from 31d5f0f to 0eb6999 Compare December 6, 2019 03:12
@renovate
renovate Bot force-pushed the renovate/change-case-4.x branch from 0eb6999 to 7908361 Compare December 19, 2019 02:18
@dhmlau dhmlau added this to the Jan 2020 milestone Dec 19, 2019
@renovate
renovate Bot force-pushed the renovate/change-case-4.x branch from 7908361 to 1ba5546 Compare December 27, 2019 15:20
@raymondfeng
raymondfeng force-pushed the renovate/change-case-4.x branch from 1ba5546 to 0a23737 Compare January 10, 2020 17:35
@renovate

renovate Bot commented Jan 10, 2020

Copy link
Copy Markdown
Contributor Author

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@jannyHou jannyHou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raymondfeng
raymondfeng merged commit ce71f6e into master Jan 10, 2020
@raymondfeng
raymondfeng deleted the renovate/change-case-4.x branch January 10, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants