docs: specify strict:false is only supported by NoSQL DBs#4443
Merged
Conversation
nabdelgadir
reviewed
Jan 20, 2020
| To create a model that allows both well-defined but also arbitrary extra | ||
| properties, you need to disable `strict` mode in model settings through the CLI | ||
| LB4 supports creating a model that allows both well-defined but also arbitrary extra | ||
| properties for **NoSQL** databases such as MongoDB. You need to disable `strict` mode in model settings through the CLI |
Contributor
There was a problem hiding this comment.
I know this isn't part of your changes, but since the change can't only be done through the CLI, can you mention you can also do it through adding {strict: false} to the model settings manually or say that it can be done through the CLI?
nabdelgadir
approved these changes
Jan 20, 2020
nabdelgadir
left a comment
nabdelgadir
left a comment
Contributor
There was a problem hiding this comment.
There's some linter problems but LGTM overall 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects to #4042. Related to loopbackio/loopback-datasource-juggler#1817
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈