Skip to content

test(repository-tests): add a test for SQL DBs strict mode warning#4483

Merged
agnes512 merged 1 commit into
masterfrom
strict-test
Jan 23, 2020
Merged

test(repository-tests): add a test for SQL DBs strict mode warning#4483
agnes512 merged 1 commit into
masterfrom
strict-test

Conversation

@agnes512

@agnes512 agnes512 commented Jan 22, 2020

Copy link
Copy Markdown
Contributor

connects to #4042
The test is for the change in loopbackio/loopback-datasource-juggler#1817

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@agnes512
agnes512 force-pushed the strict-test branch 2 times, most recently from c25608d to 5d489ef Compare January 23, 2020 15:44

@nabdelgadir nabdelgadir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good 👍

Comment thread packages/repository-tests/src/crud/freeform-properties.suite.ts Outdated
Comment thread packages/repository-tests/src/crud/freeform-properties.suite.ts Outdated
@agnes512
agnes512 merged commit eb2cb23 into master Jan 23, 2020
@agnes512
agnes512 deleted the strict-test branch January 23, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants