feat(http-caching-proxy): replace request package with axios#4637
Merged
Conversation
raymondfeng
force-pushed
the
replace-request-package
branch
from
February 12, 2020 21:20
f7d73b1 to
ecf41a7
Compare
raymondfeng
changed the title
raymondfeng
force-pushed
the
replace-request-package
branch
from
February 13, 2020 15:50
ecf41a7 to
59de4bb
Compare
7 tasks
bajtos
suggested changes
Feb 14, 2020
bajtos
reviewed
Feb 14, 2020
bajtos
reviewed
Feb 14, 2020
bajtos
reviewed
Feb 14, 2020
bajtos
reviewed
Feb 14, 2020
| url: | ||
| 'http://www.mocky.io/v2/5dade5e72d0000a542e4bd9c?mocky-delay=1000ms', | ||
| proxy: proxy.url, | ||
| resolveWithFullResponse: true, |
Member
There was a problem hiding this comment.
resolveWithFullResponse is request's counter-part of Axios' validateStatus. Have you considered configuring validateStatus on a per-test basis, as we are doing with resolveWithFullResponse now?
bajtos
reviewed
Feb 14, 2020
Member
|
Based on the investigation I did today, I am happy to choose Axios as our replacement for request 🎉 Let's improve implementation details now. Also, I am not confident that the switch from request to axios is fully backwards compatible in all edge cases, let's make this a semver-major change please. |
Member
bajtos
reviewed
Feb 14, 2020
bajtos
reviewed
Feb 14, 2020
Member
|
FYI: I opened a feature request in Axios to make their API closer to |
raymondfeng
force-pushed
the
replace-request-package
branch
from
February 14, 2020 16:46
59de4bb to
a6bd41b
Compare
raymondfeng
force-pushed
the
replace-request-package
branch
from
February 14, 2020 16:52
a6bd41b to
6a5d9c2
Compare
Contributor
Author
|
@bajtos PTAL. |
raymondfeng
force-pushed
the
replace-request-package
branch
from
February 17, 2020 17:29
6a5d9c2 to
17e5bd0
Compare
bajtos
approved these changes
Feb 18, 2020
bajtos
left a comment
bajtos
left a comment
Member
There was a problem hiding this comment.
LGTM with few tiny comments to consider.
Member
|
@raymondfeng As I commented elsewhere of before, I'd like us to release this change as a semver-major release. |
raymondfeng
force-pushed
the
replace-request-package
branch
from
February 18, 2020 20:43
17e5bd0 to
8860fbb
Compare
… client BREAKING CHANGE: [axios](https://github.com/axios/) is now used as the http client package to replace [request](https://github.com/request/request) which is now deprecated.
raymondfeng
force-pushed
the
replace-request-package
branch
from
February 18, 2020 23:18
8860fbb to
f3e55fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 2 to fix #2672
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈