feat: remove hand-written datasource stop() method#5279
Merged
Conversation
bajtos
requested review from
deepakrkris,
dhmlau,
emonddr,
hacksparrow,
jannyHou and
nabdelgadir
as code owners
April 28, 2020 06:42
This was referenced Apr 28, 2020
Use the `stop()` method provided by `juggler.DataSource` instead. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
bajtos
force-pushed
the
feat/remove-datasource-stop
branch
from
April 28, 2020 08:15
a9317e8 to
bc740e0
Compare
raymondfeng
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
stop()method provided byjuggler.DataSourceinstead.See also #5220
CI builds are failing now and that's expected, because this PR requires a newer version of juggler, I'll rebase it on top of a newer master once the relevant RenovateBot's pull request is landed.@raymondfeng @agnes512 let's continue our discussion from #5261 in this pull request please.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈