ot_sram_ctrl: change the defaut pace delay for initialization
#308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJones0
approved these changes
Dec 5, 2025
hw/opentitan/ot_sram_ctrl.c
Outdated
| ((((_reg_) < REGS_COUNT) && REG_NAMES[_reg_]) ? REG_NAMES[_reg_] : "?") | ||
|
|
||
| #define INIT_TIMER_CHUNK_NS 100000 /* 100 us */ | ||
| #define INIT_TIMER_CHUNK_US 10u /* us */ |
There was a problem hiding this comment.
Nit: the comment feels redundant given the suffix (very minor nit, feel free not to change 😅)
hw/opentitan/ot_sram_ctrl.c
Outdated
| timer_mod(s->init_timer, (int64_t)(now + INIT_TIMER_CHUNK_NS)); | ||
| int64_t now = qemu_clock_get_ns(OT_VIRTUAL_CLOCK); | ||
| timer_mod(s->init_timer, | ||
| (int64_t)(now + ((int64_t)s->init_pace_us) * 1000u)); |
There was a problem hiding this comment.
Nit: the explicit cast of the result of the addition to (int64_t) here is now redundant given the changed type of now.
| DEFINE_PROP_UINT32("wci_size", OtSramCtrlState, init_chunk_words, 0u), | ||
| DEFINE_PROP_UINT32("init-pace-us", OtSramCtrlState, init_pace_us, |
There was a problem hiding this comment.
Aside: It's not necessary to change in this PR, but it is still not clear to me: should we be using - or _ (or both) in property names?
Author
There was a problem hiding this comment.
I now try to use - for properties; however properties that are managed by readconfig file may not follow this rule.
I guess a project-wide clean up would be required at some point.
rivos-eblot
force-pushed
the
dev/ebl/sram_init_pace
branch
from
5c00540 to
28a30d1
Compare
…tialization. Make it faster to avoid ROM initialization timeout. Also add a property for fine-grained control of the pace delay. Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
rivos-eblot
force-pushed
the
dev/ebl/sram_init_pace
branch
from
28a30d1 to
308b8bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it faster to avoid ROM initialization timeout.
Also add a property for fine-grained control of the pace delay.