feat(plugins/base): split base queries to reduce GitHub API timeouts#584
Merged
lowlighter merged 2 commits intomasterfrom Oct 22, 2021
Merged
feat(plugins/base): split base queries to reduce GitHub API timeouts#584lowlighter merged 2 commits intomasterfrom
lowlighter merged 2 commits intomasterfrom
Conversation
jayvdb
approved these changes
Oct 22, 2021
Contributor
jayvdb
left a comment
jayvdb
left a comment
There was a problem hiding this comment.
This fixed the problem I was encountering
jayvdb/jayvdb@c252cce
felipecrs
added a commit
to felipecrs/felipecrs
that referenced
this pull request
Oct 22, 2021
4 tasks
|
@lowlighter I'm not sure if I should open a new issue or what, but I upgraded to the newest https://github.com/felipecrs/felipecrs/runs/3988910176?check_suite_focus=true#step:2:748 |
Owner
Author
|
@felipecrs Only the base plugin has been currently patched for GitHub API timeouts issues, the other plugins are tracked in #598 🙂 In your case it seems to be related to both |
|
Got it. Thanks a bunch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some really active users may have issues with GitHub GraphQL API, often caused timeouts with the crytpic error message:
While we cannot be sure which stats is causing this (could be because user have a lot of repo, huge repositories, lot of comments, etc.), this PR splits the base GraphQL query in smaller chunks.
Because the
baseplugin is required in order to use others plugins (except the ones that can be used withtoken: NOT_NEEDED), Metrics (including Insights) were totally unusable for these users.If a specific stats cannot be retrieved, for now
NaNwill be displayed instead (display will be improved in a future PR)Because Insights actually use the same engine, it'll also improve its performance.
Note that this PR does not solve all issues for "huge users", who may still encounter issues with other plugins, but will still be able to use most of Metrics 🙂