Add support for LUANTI_GAME_PATH and LUANTI_WORLD_PATH#16816
Merged
sfan5 merged 2 commits intoluanti-org:masterfrom Mar 11, 2026
Merged
Add support for LUANTI_GAME_PATH and LUANTI_WORLD_PATH#16816sfan5 merged 2 commits intoluanti-org:masterfrom
sfan5 merged 2 commits intoluanti-org:masterfrom
Conversation
wsor4035
added
@ Startup / Config / Util
@ Engine Core
cx384
reviewed
Jan 8, 2026
apteryks
force-pushed
the
add-support-for-luanti-environment-variables
branch
from
ac625ee to
79ddbc4
Compare
sfan5
reviewed
Jan 8, 2026
Zughy
added
the
Action / change needed
apteryks
force-pushed
the
add-support-for-luanti-environment-variables
branch
from
79ddbc4 to
ae31211
Compare
cx384
removed
the
Action / change needed
Member
|
I took the liberty to reformat the code a bit to make similar functions look similar. However, please also document these environment variables in |
apteryks
force-pushed
the
add-support-for-luanti-environment-variables
branch
from
1c91504 to
9b500bb
Compare
Contributor
Author
Done, and doing so I noticed about MINETEST_USER_PATH, so I've adjusted that to LUANTI_USER_PATH (with supporting code) as well. Thanks for the review! |
apteryks
force-pushed
the
add-support-for-luanti-environment-variables
branch
from
9b500bb to
a52414c
Compare
sfan5
requested changes
Jan 12, 2026
apteryks
force-pushed
the
add-support-for-luanti-environment-variables
branch
from
a52414c to
6013ae6
Compare
sfan5
requested changes
Jan 16, 2026
Zughy
added
the
Action / change needed
apteryks
force-pushed
the
add-support-for-luanti-environment-variables
branch
from
6013ae6 to
c58156f
Compare
Zughy
removed
the
Action / change needed
nerzhul
reviewed
Jan 23, 2026
nerzhul
reviewed
Jan 23, 2026
apteryks
force-pushed
the
add-support-for-luanti-environment-variables
branch
from
c58156f to
ce84b79
Compare
Also fix duplicate warnings and an off-by-one issue in the win32 code. * src/content/subgames.cpp (getSubgamePathEnv): Deprecate MINETEST_SUBGAME_PATH in favor of LUANTI_GAME_PATH. (getWorldPathEnv): Deprecate MINETEST_WORLD_PATH in favor of LUANTI_WORLD_PATH. (getEnvModPaths): Deprecate MINETEST_MOD_PATH in favor of LUANTI_MOD_PATH. * src/porting.cpp (setSystemPaths): Deprecate MINETEST_USER_PATH in favor of LUANTI_USER_PATH. [win32]: Fix off-by-one issue in GetEnvironmentvariable length check. * doc/luanti.6: Update doc. * doc/world_format.md: Likewise. * src/content/subgames.h: Likewise. * src/unittest/test_servermodmanager.cpp (TestServerModManager::runTests): Adjust to use LUANTI_ prefixed environment variables. Co-authored-by: Liliana Marie Prikler <liliana.prikler@gmail.com> Co-authored-by: SmallJoker
apteryks
force-pushed
the
add-support-for-luanti-environment-variables
branch
from
ce84b79 to
1bcde7e
Compare
SmallJoker
reviewed
Mar 8, 2026
Contributor
Author
|
Thanks, everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add compact, short information about your PR for easier understanding:
Naming consistency.
This change was authored not by me but by Liliana Marie Prikler; as far as I know they haven't used AI to author it.
To do
This PR is a Ready for Review.
How to test
I'm testing in an environment set up by Guix, via e.g.: