Visit inner expression of AstExprInstantiate, add JSON encoding visitor for AstExprInstantiate
#2115
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kampfkarren
reviewed
Nov 29, 2025
Kampfkarren
reviewed
Nov 29, 2025
Contributor
Author
|
conflict resolved |
alexmccord
reviewed
Jan 4, 2026
alexmccord
reviewed
Jan 4, 2026
checkraisefold
force-pushed
the
fix-instantiate-expr
branch
from
0160a10 to
c7050d7
Compare
Contributor
Author
|
review resolved |
Contributor
Author
|
i have the distinct feeling the test failure is not caused by this pr |
Contributor
|
Yeah, definitely unrelated. You could try bumping the time limit to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After release 0.701, including the merging of #1980, I noticed an issue where functions called with the turbofish as their only call were linted as unused.
Upon further investigation, I discovered 2 things:
AstJsonEncoderwhich madeluau-astspit out a nonsensical ASTexpr, that being the function being instantiated upon, was never being visited, seemingly due to an oversightThis PR fixes both issues. The only thing I'm unsure of is if it's proper to do the
LUAU_ASSERTI added inAstJsonEncoder. The assertion will fail if you have the flag that allows for generating it in the AST on, but have this specific flag off, and then attempt to generate the encoded JSON for it. Maybe it should just return false instead of failing an assertion?Closes #2113