Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
codeberg.org/readeck/go-readability/v2 v2.1.0 h1:1T72CzXu4nrZr/DA1A5fAkaVsTMx/LSALPkSSZY+NWI=
codeberg.org/readeck/go-readability/v2 v2.1.0/go.mod h1:x3WG9GpWWnkRb7ajP1NmOKSHbafxNUb736lrDZXeXrs=
codeberg.org/readeck/go-readability/v2 v2.1.1 h1:1tEwxFuUqDRP5JABzDHXGWRx5p9S7TElS3U8qQwXC5Y=
codeberg.org/readeck/go-readability/v2 v2.1.1/go.mod h1:x3WG9GpWWnkRb7ajP1NmOKSHbafxNUb736lrDZXeXrs=
github.com/andybalholm/cascadia v1.3.3 h1:AG2YHrzJIm4BZ19iwJ/DAua6Btl3IwJX+VI4kktS1LM=
Expand Down
14 changes: 11 additions & 3 deletions mise.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,13 @@ run = "bun install"
description = "Install Bun dependencies"

[tasks.test]
run = "go test ./..."
depends = ["test:*"]
description = "Run tests"

[tasks."test:go"]
run = "go test ./..."
description = "Run Go tests"

[tasks.lint]
depends = ["lint:*"]
description = "Run all linters"
Expand All @@ -47,9 +51,13 @@ run = "bunx prettier --write ."
description = "Format with Prettier"

[tasks.codegen]
run = "echo 'No codegen tasks'"
depends = ["codegen:*"]
description = "Run code generation"

[tasks."codegen:go"]
run = "go mod tidy"
description = "Run Go codegen"

[tasks.ci]
depends = ["install", "lint", "test"]
depends = ["lint", "test"]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

A tarefa install foi removida das dependĂȘncias da tarefa ci. Embora algumas ferramentas como go test possam baixar dependĂȘncias automaticamente, Ă© uma boa prĂĄtica ter uma etapa de instalação explĂ­cita no pipeline de CI para garantir que todas as dependĂȘncias do projeto (Go e Bun) estejam presentes antes de executar linters e testes. Isso pode evitar falhas inesperadas e otimizar o cache de dependĂȘncias.

Se a intenção for que o pipeline de CI execute mise run install como um passo separado, esta alteração estĂĄ correta. No entanto, se a tarefa ci deve ser um comando Ășnico e autossuficiente, considere adicionar install de volta.

Suggested change
depends = ["lint", "test"]
depends = ["install", "lint", "test"]

description = "Run CI pipeline"