Conversation
lufy90
commented
May 13, 2026
- fix filters also filter in authro detail page unexpectedly
- fix while get 401 response from API, return to login page
1. fix filters also filter in authro detail page unexpectedly 2. fix while get 401 response from API, return to login page
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe67713da2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private val _events = MutableSharedFlow<Unit>( | ||
| extraBufferCapacity = 1, | ||
| onBufferOverflow = BufferOverflow.DROP_OLDEST, | ||
| ) |
There was a problem hiding this comment.
Replay unauthorized event for late subscribers
The unauthorized signal can be lost because _events is a MutableSharedFlow with replay = 0 (default), so an early notifyUnauthorized() emitted before AppNav starts collecting will not be delivered; in that startup race, the token is cleared in memory but navigation back to login never happens until another request emits a new 401. This makes session-expiry handling nondeterministic on app launch/resume when the first protected API call returns 401 quickly.
Useful? React with 👍 / 👎.