Skip to content

Fix android issues: filters also filter in author detail page#3

Open
lufy90 wants to merge 1 commit into
mainfrom
dev
Open

Fix android issues: filters also filter in author detail page#3
lufy90 wants to merge 1 commit into
mainfrom
dev

Conversation

@lufy90
Copy link
Copy Markdown
Owner

@lufy90 lufy90 commented May 13, 2026

  1. fix filters also filter in authro detail page unexpectedly
  2. fix while get 401 response from API, return to login page

1. fix filters also filter in authro detail page unexpectedly
2. fix while get 401 response from API, return to login page
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe67713da2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +8 to +11
private val _events = MutableSharedFlow<Unit>(
extraBufferCapacity = 1,
onBufferOverflow = BufferOverflow.DROP_OLDEST,
)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replay unauthorized event for late subscribers

The unauthorized signal can be lost because _events is a MutableSharedFlow with replay = 0 (default), so an early notifyUnauthorized() emitted before AppNav starts collecting will not be delivered; in that startup race, the token is cleared in memory but navigation back to login never happens until another request emits a new 401. This makes session-expiry handling nondeterministic on app launch/resume when the first protected API call returns 401 quickly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants