feature/665 - Add NoSecurity decorator#684
Merged
WoH merged 2 commits intolukeautry:masterfrom May 7, 2020
Merged
Conversation
Resolves feature request lukeautry#665 by adding a NoSecurity decorator that can be used to override the Security decorator on a class.
4 tasks
4 tasks
Collaborator
|
LGTM, thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves feature request #665 by adding a
NoSecuritydecorator that can be used to override theSecuritydecorator on a class.All Submissions:
Closing issues
Put
closes #XXXX(where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.If this is a new feature submission:
Potential Problems With The Approach
The
noSecurityDecoratorsvariable name could be seen as a little ambiguous, but is not publicly visible.Test plan
Tests will be added once the maintainers are happy with my approach in the PR (and I get to grips with these unit tests).Ones I can think of are:MethodGenerator.getSecurityreturns empty array whenNoSecuritydecorator is used.I can't seem to find any way of testing invalid decorator usage, but have verified that the following errors are thrown as expected.
ControllerGenerator.getSecuritythrows when aNoSecuritydecorator is used.MethodGenerator.getSecuritythrows when multipleNoSecuritydecorators are used.MethodGenerator.getSecuritythrows whenNoSecurityandSecuritydecorators are used.