Merged
Conversation
While the current implementation does well for emulating an avant-garde synthesizer theme the name does sound a bit misleading. Other than that, this also adds a baseline to sort of account for the allocations by the application itself. "Test" added.
| rate := float64(diff)/memSampleRate.Seconds() - baseline | ||
| // If it becomes too high it becomes inaudible. | ||
| // Limit at 3.6 Roentgen. | ||
| rate = math.Min(rate, float64(sr)/3.6) |
| const sr = beep.SampleRate(44100) | ||
| const memSampleRate = 100 * time.Millisecond | ||
| const memSampleRate = 500 * time.Millisecond | ||
| const baseline = 160 |
Owner
There was a problem hiding this comment.
ideally we could measure this empirically somehow, but I suppose this is better than nothing
Contributor
Author
There was a problem hiding this comment.
Yeah, it was a bit "twitchy" with 100... At least now if you make a burst of allocations you will feel the pain for half a second :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the current implementation does well for emulating an avant-garde synthesizer theme the package name is a bit misleading. I attempt to fix that.
Other than that, this also adds a baseline to sort of account for the allocations by the application itself.
"Test" added. Confirmed it sorta-kinda works.