Skip to content

feat: improve homebrew-tap PR body and remove git config#36

Merged
luxass merged 4 commits into
mainfrom
feat/homebrew-pr-improvements
May 24, 2026
Merged

feat: improve homebrew-tap PR body and remove git config#36
luxass merged 4 commits into
mainfrom
feat/homebrew-pr-improvements

Conversation

@luxass
Copy link
Copy Markdown
Owner

@luxass luxass commented May 24, 2026

Summary

  • Remove explicit git config user.name/email; commits are attributed to the GitHub App or PAT owner automatically.
  • Remove duplicate checkout step.
  • Generate structured PR body with:
    • Summary of what was updated
    • Table of targets with SHA256 checksums
    • Link to the release
  • Update documentation to reflect changes.

Example PR body

## Summary

Automated update of the `actioneer` Homebrew formula to `v0.1.12`.

## Updated targets

| Target | SHA256 |
| --- | --- |
| `x86_64-apple-darwin` | `abc123...` |
| `aarch64-apple-darwin` | `def456...` |
| `x86_64-unknown-linux-gnu` | `ghi789...` |
| `aarch64-unknown-linux-gnu` | `jkl012...` |

## Links

- [Release v0.1.12](https://github.com/luxass/actioneer/releases/tag/v0.1.12)

Summary by CodeRabbit

Release Notes

  • Documentation

    • Updated workflow documentation to describe automated PR generation with structured summaries.
  • Improvements

    • Pull requests now include detailed checksums and target information in structured format.
    • Enhanced authentication handling for workflow operations.

Review Change Stack

- Remove explicit git user.name/email configuration; commits are
  attributed to the GitHub App or PAT owner automatically.
- Remove duplicate checkout step.
- Generate structured PR body with summary, updated targets table
  with SHA256 checksums, and link to the release.
- Update documentation to reflect PR body changes.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1a086aba-b28e-4af3-97e0-4ff1b8ac384b

📥 Commits

Reviewing files that changed from the base of the PR and between 8f6ed04 and dc65183.

📒 Files selected for processing (2)
  • .github/workflows/reusable-homebrew-tap.md
  • .github/workflows/reusable-homebrew-tap.yaml

Walkthrough

This PR enriches the Homebrew tap reusable workflow with improved authentication handling, credential persistence for repository operations, and structured PR descriptions. The workflow now supports token fallback, maintains credentials for pushing updates, and generates detailed PR bodies with SHA256 checksums and release metadata.

Changes

Homebrew tap workflow improvements

Layer / File(s) Summary
Job description documentation update
.github/workflows/reusable-homebrew-tap.md
Job description clarified to document that the update-formula step creates a PR with a structured summary of updated targets and checksums.
Authentication and credential persistence setup
.github/workflows/reusable-homebrew-tap.yaml
GH_TOKEN environment variable now resolves to secrets.token when provided, otherwise falls back to the GitHub App token. Tap repository checkout configured to persist credentials (persist-credentials: true) to enable later branch push operations.
Dynamic PR body construction with SHA256 checksums
.github/workflows/reusable-homebrew-tap.yaml
PR creation step refactored to dynamically generate a markdown body in-shell that includes a table mapping targets to SHA256 checksums and a release link section, replacing the static message previously passed to gh pr create.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • luxass/shared-workflows#24: Updates token resolution in the same workflow by simplifying how gh release download authenticates with the provided token or GitHub App token fallback.

  • luxass/shared-workflows#28: Modifies the tap repository checkout configuration to ensure proper credentials and context are available for the gh release download step.

  • luxass/shared-workflows#32: Adjusts GitHub App token and checkout credential setup for repository operations and PR creation, with overlapping authentication and persistence concerns.

Poem

A hop, a skip, through GitHub's tap,
With checksums hashed in markdown wrap,
Credentials persist, tokens fall through,
Each PR now shines with structured view! 🐰✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/homebrew-pr-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@luxass luxass marked this pull request as ready for review May 24, 2026 06:17
@luxass luxass merged commit 41d22d1 into main May 24, 2026
3 of 4 checks passed
@luxass luxass deleted the feat/homebrew-pr-improvements branch May 24, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant