Skip to content

fix: add --repo flag and configurable git identity for homebrew-tap#40

Merged
luxass merged 4 commits into
mainfrom
fix/homebrew-tap-download-repo
May 24, 2026
Merged

fix: add --repo flag and configurable git identity for homebrew-tap#40
luxass merged 4 commits into
mainfrom
fix/homebrew-tap-download-repo

Conversation

@luxass

@luxass luxass commented May 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Added --repo "$GITHUB_REPOSITORY" to gh release download so it works without a local git checkout
  • Added configurable git-user-name and git-user-email inputs with sensible defaults (luxass-homebrew)
  • Updated documentation in reusable-homebrew-tap.md

Related

Fixes the 'Author identity unknown' error when the workflow tries to commit to the tap repository.

Summary by CodeRabbit

  • New Features
    • Reusable Homebrew tap workflow now supports configurable git user name and email inputs for controlling commit author identity during formula updates. Default values ensure seamless operation.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0fac8657-e9ef-4171-93f8-5f0c02fd3fda

📥 Commits

Reviewing files that changed from the base of the PR and between 6c46d97 and f6b90f2.

📒 Files selected for processing (2)
  • .github/workflows/reusable-homebrew-tap.md
  • .github/workflows/reusable-homebrew-tap.yaml

Walkthrough

This PR extends the reusable Homebrew tap workflow to accept optional inputs that customize the Git author identity (name and email) used when creating commits. The workflow inputs are declared with sensible defaults and applied when configuring Git during PR creation, with documentation added to guide callers.

Changes

Git Author Identity Configuration

Layer / File(s) Summary
Git Author Identity Inputs
.github/workflows/reusable-homebrew-tap.yaml, .github/workflows/reusable-homebrew-tap.md
New git-user-name and git-user-email inputs (with defaults luxass-homebrew and luxass-homebrew[bot]@users.noreply.github.com``) are declared in the workflow and used to configure Git identity in the PR creation step; documentation is updated to reflect these options.

🎯 1 (Trivial) | ⏱️ ~3 minutes

A workflow gains the author's voice so clear,
With inputs to customize who commits here,
From luxass-homebrew's gentle hand,
The tap updates stand proud and grand.
Configurable, flexible, ready to brew,
This reusable recipe makes names true! 🍺

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: adding --repo flag and configurable git identity (git-user-name and git-user-email inputs) to the homebrew-tap workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/homebrew-tap-download-repo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@luxass luxass merged commit c73809a into main May 24, 2026
4 checks passed
@luxass luxass deleted the fix/homebrew-tap-download-repo branch May 24, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant