Fix missing link to required library in Windows when XLINK_LIBUSB_SYSTEM is ON#79
Merged
themarpe merged 4 commits intoluxonis:masterfrom Jun 17, 2024
Merged
Fix missing link to required library in Windows when XLINK_LIBUSB_SYSTEM is ON#79themarpe merged 4 commits intoluxonis:masterfrom
themarpe merged 4 commits intoluxonis:masterfrom
Conversation
Contributor
Author
|
The Windows failure is unrelated and related to luxonis/depthai-core#1037 and cpp-pm/hunter#747 . |
themarpe
requested changes
Jun 17, 2024
Co-authored-by: TheMarpe <martin.peterlin7@gmail.com>
themarpe
approved these changes
Jun 17, 2024
Contributor
Author
|
The merge confused the PR, let me do it from scratch. |
Contributor
Author
Ok, now it is clean, let me know if it is ok to merge with squash or you prefer that I cleanup the history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PathCchRemoveFileSpecfunction contained inPathcch.libis called in the code in Windows (seeXLink/src/pc/Win/src/win_usb_host.cpp
Line 39 in 6d2a0dd
Pathcch.liblibrary should be linked even if XLINK_LIBUSB_SYSTEM is set to ON.