This repository was archived by the owner on Feb 22, 2024. It is now read-only.
feat!(position): optimize max_len align & add fixed_col align#45
Open
utkarshgupta137 wants to merge 1 commit intolvimuser:mainfrom
Open
feat!(position): optimize max_len align & add fixed_col align#45utkarshgupta137 wants to merge 1 commit intolvimuser:mainfrom
utkarshgupta137 wants to merge 1 commit intolvimuser:mainfrom
Conversation
Author
|
@lvimuser Have you had a chance to look at this? I've been using this for over a month now. There is only minor 1 issue with this which is that if I enter text after my selected column, then the virtual text will hide the text that I've entered. Is there a setting I'm not seeing which will allow the virt_text to be hidden behind actual text instead? Fiddling with priority didn't help. |
Owner
|
I haven't, no. You may look into the |
|
@utkarshgupta137 Having said that, you can avoid the issue by getting the current line length and setting the -- inside the loop
-- probably not the best way to get line length
line_len = string.len(vim.api.nvim.get_cur_line())
virt_text_win_col = math.max(opts.position.padding, line_len + 1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've changed the max_len_align/padding to a new key
positionso that the user can choose one of 3 options instead of having 2 bools. It should also simplify adding more alignment modes in the future (such as "right" from rust-tools.nvim).I've also changed the code to use the
virt_text_win_col, so that we don't have to calculate the padding for each line.