propertiesdialog: small enhancements for UI consistency#1178
propertiesdialog: small enhancements for UI consistency#1178Fat-Zer wants to merge 1 commit intolxqt:masterfrom
Conversation
|
This looks good, granted translations would be wiped unfortunately, unless manually edited (which is a hassle.) Apart from that, this has merge conflicts that need to be resolved before being able to merge. |
|
Actually I was confused: labels of actionable widgets (apart from QGroupBox) should have colons. |
As for now most of them don't have colons, so I've assumed it was the preferred style. I can update the PR adding the missing one instead if you wish. |
Please do. You can refer to PCManFM-Qt's Preferences dialog to see the general convention. Unfortunately this will result in many translations being invalidated (as the entire string is used in " px" is used in PCManFM-Qt and probably is the correct string. |
- add a space before "px" suffix - add missing colons ':' in the form's labels
|
done
Well... that's expected expenses of gettext-like translations.
There is already yet another line edit with " px" suffix, so it should catch up automatically even without the rest of lxqt. |
|
I managed to preserve translations in |
remove colons ':' in the form's labels