Upload progress recipe

[aried3r]

Let's have it, @swankjesse! ;)

There's a few things I'm not quite sure about how to handle (basically the whole writeTo() method), so I'm awaiting your comments. But I hope I'll stay below 10 this time :p

[swankjesse]

Could you change this so that it wraps another RequestBody? That way the caller can do whatever they want: upload data being generated, a file, or whatever.

[aried3r]

I wanted to, but from what I've gathered I can't get the upload data out of the request body, so it would have to look like this, file being passed to the RequestBody and again to the ProgressRequestBody so it can be accessed for contentLength() etc.

File file = new File("website/static/logo-square.png");
RequestBody requestBody = RequestBody.create(MEDIA_TYPE_PNG, file);
Request request = new Request.Builder()
  .header("Authorization", "Client-ID " + IMGUR_CLIENT_ID)
  .url("https://api.imgur.com/3/image")
  .post(new ProgressRequestBody(requestBody, file, progressListener)) // Here file is passed a second time
  .build();

[swankjesse]

You can, but you need to be a bit sneaky. You'd just need to call delegate.writeTo(buffer(progressSink(sink))) in your own writeTo method.

[swankjesse]

I think this is pretty awesome. Consider building on the PostFile endpoint instead. It's simpler & so there's less to distract from the main content of the example. With this one it's unclear whether you're showing me about multipart vs. progress monitor.

[swankjesse]

This is great!

[aried3r]

With this one it's unclear whether you're showing me about multipart vs. progress monitor.

The only difference is .header("Authorization", "Client-ID " + IMGUR_CLIENT_ID), I'm not even explicitly using a multipart builder, I'm not passing a name or a description or anything, but I can change it, if you want.

The reason why I used the imgur example was that the README is below 2KB which means there's no real progress to watch, but I guess it should just serve as an example?

[swankjesse]

(You can look at the PostStreaming example to see an unknown content length in practice.)

[swankjesse]

@aried3r follow me on the PostStreaming thing?

[aried3r]

Sorry, been busy. I'll try to get this done during the weekend. Stay tuned! ;)

[swankjesse]

I'm going to close this for now. If you'd like to revisit, please do!

[LouisCAD]

Does the code found here sticks to your recommendations @swankjesse ?