chore(devcontainer): install with pnpm instead of bun - #6
Merged
Conversation
The container ran `bun install --frozen-lockfile`, but the repo has no bun lockfile — it is on pnpm 11.10.0 with pnpm-lock.yaml, so a fresh container either failed or resolved dependencies that did not match CI. corepack reads the version from package.json `packageManager`, so this cannot drift from the lockfile. The bun feature stays: it is not the package manager, it is what AGENTS.md uses for `bun:sqlite` test-data seeding.
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev container ran
bun install --backend=copyfile --frozen-lockfile, but this repo has no bun lockfile — it is on pnpm 11.10.0 withpnpm-lock.yaml. A fresh container either failed at install or resolved dependencies that did not match CI.Now:
corepack enable && pnpm install --frozen-lockfile. corepack reads the version frompackage.jsonpackageManager, so the container cannot drift from the lockfile and there is no hardcoded version to go stale.The bun feature stays installed. It is not the package manager — it is what
AGENTS.mduses forbun:sqliteVACUUM INTOtest-data seeding.Also renames the container from "T3 Code Dev" to "Marcode Dev".
Note: upstream's
.devcontainer/devcontainer.jsonwas byte-identical to ours before this change, so upstream is broken the same way. This is a deliberate Marcode divergence in a file upstream rarely touches.