revert(gha): bundle action with esbuild - #455
Closed
macalbert wants to merge 1 commit into
Closed
Conversation
This reverts commit 5f4e6ab.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
github-actions
Bot
added
documentation
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts PR #454 by restoring the GitHub Action and related tooling back to the pre-esbuild state (ncc bundling, ts-node usage, and TypeScript 6 catalog), along with reverting the associated documentation and script updates.
Changes:
- Switch GitHub Action bundling back to
@vercel/nccand remove the esbuild build script. - Revert local TypeScript execution paths from
tsxback tots-node(CDK + pack/install workflow). - Roll back documentation/changelog/ADR content that documented the esbuild/tsx migration.
Reviewed changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/iac/package.json |
Swap IaC dev dependency from tsx back to ts-node. |
src/iac/cdk.json |
Revert CDK execution from tsx to ts-node. |
scripts/README.md |
Update script docs to reflect ncc bundling and ts-node execution. |
scripts/pack-and-install.ts |
Change script execution entry from tsx shebang to ts-node loader approach. |
scripts/build-github-action.mjs |
Remove esbuild bundling script. |
pnpm-workspace.yaml |
Revert workspace catalog from TS 7/tsx to TS 6/ts-node. |
pnpm-lock.yaml |
Lockfile updates consistent with reverting dependencies/tooling. |
package.json |
Restore build:gha to ncc, add @vercel/ncc, switch local install to ts-node loader. |
e2e/cli.test.ts |
Update E2E setup to run pack/install using ts-node loader. |
docs/changelogs/gha.md |
Remove the unreleased changelog entry describing the esbuild/tsx migration. |
docs/adr/0010-github-action-bundler.md |
Remove the ADR that justified esbuild bundling. |
docs/adr/0006-monorepo-structure.md |
Update monorepo ADR to reflect ncc bundling again. |
CONTRIBUTING.md |
Update contributor docs to indicate ncc-based GHA bundling. |
.github/skills/common-security/SKILL.md |
Update security guidance to reference ncc bundling. |
.github/copilot-instructions.md |
Update repo instructions to reflect ncc bundling. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env tsx | |||
| #!/usr/bin/env node --loader=ts-node/esm | |||
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "app": "pnpm exec tsx bin/main.ts", | |||
| "app": "npx ts-node --prefer-ts-exts bin/main.ts", | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #454 at the user's explicit request.
This restores
mainto its state before the GitHub Action bundler migration.Changes
Testing
Related
#454