Skip to content

fix(website): stabilize animated terminal - #466

Merged
macalbert merged 2 commits into
mainfrom
macalbert-fix-mobile-terminal-scroll
Jul 26, 2026
Merged

fix(website): stabilize animated terminal#466
macalbert merged 2 commits into
mainfrom
macalbert-fix-mobile-terminal-scroll

Conversation

@macalbert

@macalbert macalbert commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Summary

Stabilizes the animated hero terminal so scene playback no longer changes page height or triggers mobile scroll anchoring. The terminal demo now mirrors the current Envilder CLI output for pull and single-secret push operations.

Changes

  • Keep the terminal viewport at a fixed height and follow the latest rendered line without creating a nested touch-scroll area.
  • Update the setup scene to show the current PUSHING SECRET and SECRET PUSHED output.
  • Update the CLI scene to show the current RESOLVING SECRETS and LEVEL CLEARED output.

Testing

  • pnpm --dir src/website format:check
  • pnpm --dir src/website lint
  • pnpm --dir src/website build
  • pnpm lint
  • pnpm test (353 passed)
  • Responsive browser validation at 375x812, 768x1024, and 1440x900 in retro and light themes
  • Mobile scroll measurement remains stable across a complete terminal rotation
  • pnpm verify:gha (the bundle regenerated from main differs from the versioned bundle; this PR has no GitHub Action diff)

Related

N/A

Summary by CodeRabbit

  • Enhancements
    • Improved the hero terminal animation with clearer, step-by-step setup, push, and resolution output.
    • Added visual separators and highlighted status messages to make terminal activity easier to follow.
    • Updated terminal playback to automatically keep the latest output visible.
    • Refined terminal screen sizing and overflow behavior for a cleaner presentation.

Fix mobile scroll jumps by keeping the animated terminal viewport fixed.

Match pull and push scenes to the current CLI output.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 26, 2026 14:30
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@github-actions github-actions Bot added bug Something isn't working size/M Medium change — 50-199 lines / 5-9 files labels Jul 26, 2026
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 05c30ab5-5bb0-40b7-81a1-d6dddd689cf8

📥 Commits

Reviewing files that changed from the base of the PR and between e272c91 and da19a77.

📒 Files selected for processing (1)
  • src/website/src/components/Hero.astro

Walkthrough

The hero terminal scenes now show structured highlighted CLI output with separators. Terminal playback uses fixed-height overflow handling and requestAnimationFrame-based scrolling to keep newly rendered content visible, while resetting scroll position at scene start.

Changes

Hero terminal experience

Layer / File(s) Summary
Structured terminal scene output
src/website/src/components/Hero.astro
Setup and CLI scenes now render separated, highlighted status lines with updated masked key and environment-file output.
Terminal playback scrolling
src/website/src/components/Hero.astro
The terminal uses fixed height and hidden overflow, schedules scrolling to the newest line during instant and typed rendering, and resets scroll position when playback starts.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: stabilizing the website's animated terminal.
Description check ✅ Passed The description covers summary, changes, testing, and related notes, though it doesn't follow the exact template headings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch macalbert-fix-mobile-terminal-scroll

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR stabilizes the website hero’s animated terminal playback so it no longer affects overall page height (preventing mobile scroll anchoring), while updating the demo scenes to reflect current Envilder CLI output for pull and single-secret push.

Changes:

  • Fix the terminal viewport to a constant height and clip overflow to keep the page layout stable.
  • Add “follow latest line” scrolling behavior during playback without creating a user-scrollable nested region.
  • Refresh the “setup” and “cli” scenes to match current CLI messaging (PUSHING SECRET / SECRET PUSHED, RESOLVING SECRETS / LEVEL CLEARED).

@macalbert macalbert self-assigned this Jul 26, 2026
Copilot AI review requested due to automatic review settings July 26, 2026 14:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@macalbert
macalbert merged commit 52d985a into main Jul 26, 2026
24 checks passed
@macalbert
macalbert deleted the macalbert-fix-mobile-terminal-scroll branch July 26, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size/M Medium change — 50-199 lines / 5-9 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants