get_query_table_aliases(query) is far from being final

[macbre]

Fixes #97

[macbre]

@bandrisca - please follow pylint suggestions and reformat the code with black.

[bandrisca]

@bandrisca - please follow pylint suggestions and reformat the code with black.

@macbre sorry, I do not know how to do that. Can you please format it for me or tell me how can I do it?

[macbre]

@bandrisca: no worries 🙂 In order to reformat the code simply run the following:

pip install black
black .

And commit the changes made by the black tool.

---

As for the pylint errors - these places need some changes:

************* Module sql_metadata
sql_metadata.py:381:32: C0303: Trailing whitespace (trailing-whitespace)
sql_metadata.py:383:0: C0301: Line too long (101/100) (line-too-long)
sql_metadata.py:389:35: C0303: Trailing whitespace (trailing-whitespace)
sql_metadata.py:390:41: C0303: Trailing whitespace (trailing-whitespace)
sql_metadata.py:397:0: C0301: Line too long (114/100) (line-too-long)
sql_metadata.py:397:0: W0311: Bad indentation. Found 11 spaces, expected 12 (bad-indentation)
sql_metadata.py:402:0: C0303: Trailing whitespace (trailing-whitespace)

[bandrisca]

@bandrisca: no worries 🙂 In order to reformat the code simply run the following:

pip install black
black .

And commit the changes made by the black tool.

As for the pylint errors - these places need some changes:

************* Module sql_metadata
sql_metadata.py:381:32: C0303: Trailing whitespace (trailing-whitespace)
sql_metadata.py:383:0: C0301: Line too long (101/100) (line-too-long)
sql_metadata.py:389:35: C0303: Trailing whitespace (trailing-whitespace)
sql_metadata.py:390:41: C0303: Trailing whitespace (trailing-whitespace)
sql_metadata.py:397:0: C0301: Line too long (114/100) (line-too-long)
sql_metadata.py:397:0: W0311: Bad indentation. Found 11 spaces, expected 12 (bad-indentation)
sql_metadata.py:402:0: C0303: Trailing whitespace (trailing-whitespace)

I istalled "black" and it successfully reformatted the code, but still I see the length of the lines are more than 100 chars.
Do I have to modify them manually?
Did "black" remove unwanted whitespaces and bad indentations?
I compared the original and the reformatted code but found no change.
Is there a predifined black setup for github?

[macbre]

Please commit the changes made by black and we'll see what needs to be updated.

[bandrisca]

hi @macbre , I am not sure about what I am doing, but finally I managed to upload the formatted code. Is it ok now, or too late?

[macbre]

@bandrisca - still no improvement. Check the outputs of the checks listed below. Additionally, unit tests do not pass for the updated functions.

[macbre]

black passes now 🎉

[macbre]

@bandrisca - do you need any help with this one?

[macbre]

@bandrisca - #121 introduced a completely new SQL parser and new API. Closing this in favour of #121.