Merged
Conversation
yseto
force-pushed
the
version-info
branch
2 times, most recently
from
48fa0cc to
e2143d4
Compare
yseto
force-pushed
the
version-info
branch
3 times, most recently
from
38efbe8 to
cc4b622
Compare
lufia
approved these changes
May 8, 2025
Comment on lines
+1
to
+2
| # This VERSION variable indicates the latest tag. | ||
| VERSION = $(subst v,,$(shell git describe --abbrev=0 --tags)) |
Contributor
There was a problem hiding this comment.
note: We guard to not to be able to ship added commits after tagged commit by our workflow (not GitHub Workflows).
Contributor
Author
|
Thanks for your review. |
This was referenced May 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.