Minimal changes to add clang support#134
Merged
Merged
Conversation
…ang++) Fix cherry-pick conflicts: epoch1/cuda/ee_mumu/SubProcesses/Makefile Add the clang lib directory to -L explicitly. Use -lomp instead of -lgomp for clang.
Member
Author
|
Self-merging. The initial version of these fixes were in the klas2 PR #132 but I find it neater to separate the SIMD and clang issues. Note that the clang build errors in fact were already present in master. |
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Mar 21, 2021
Fix conflicts in epoch1/cuda/ee_mumu/SubProcesses/Makefile This merge essentially merges the clang PR madgraph5#134
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes two build warnings (unused variables) and especially a link error for runTest.exe.
To solve the link error, the fix is to add the clang library via -L explicitly.
Initially I had also used -lomp instead of -lgomp: later on, however, I realised that -lgomp could be used also for clang, as libgomp.so is a symlink to libomp.so (in all clang installations I found on SFT cvmfs):