Disable mirror processes (nprocesses=2 in pptt) + Add process name to library names#396
Merged
Conversation
…denominators' by vector 'denominators[1]'
….1.1_lo_vectorization/madgraph/iolibs/export_cpp.py (check tkdiff 2.7.0_gpu/madgraph/iolibs/export_cpp.py 3.1.1_lo_vectorization/madgraph/iolibs)
…t! must fix also the template...
…LL ASSUME NPROCESSES == 1 *** Fix codegen templates, regenerate ggtt auto, fix also ggtt manual
… "cp -i" (do not prompt if the file already exists... not sure why I have not seen this before)
…rate ggtt auto, copy manually elsewhere
This was referenced Mar 8, 2022
…aced... However this demands overriding ProcessExporterCPP.copy_template in export_cpp upstream. Maybe another option is possible in the Makefile...
…akefiles Revert "[pptt] prepare Makefile templates with %(processid_short)s to be replaced..." This reverts commit 8eaecca. Revert "[pptt] rename libraries as suggested by @roiser to avoid clashes madgraph5#397" This reverts commit 4beacf5.
…roiser to avoid clashes madgraph5#397 NB: only the cxx and cu libraries need to be renamed, while the common library includes only common src files for now...
valassi
changed the title
Member
Author
|
This is now complete. It addresses two issues for pptt
|
Member
Author
|
All checks passed, self merging |
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Apr 7, 2023
valassi
added a commit
to mg5amcnlo/mg5amcnlo_cudacpp
that referenced
this pull request
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP PR for issue #343
This fixes #343, but we should still find an example with nprocesses>1 (#272) even in the absence of mirror processes (is there any such thing? otherwise can the "denominators[1]" array become a scalar again?)
Later on I might also add a patch for pptt library names as discussed with @roiser