Add matrix.pdf files to the git repo#854
Conversation
… my O/S - no change, no new files
…pt on my O/S - three new jpg/html files Changes to be committed: modified: susy_gg_t1t1.mad/CODEGEN_mad_susy_gg_t1t1_log.txt new file: susy_gg_t1t1.mad/SubProcesses/P1_gg_t1t1x/card.jpg new file: susy_gg_t1t1.mad/SubProcesses/P1_gg_t1t1x/diagrams.html new file: susy_gg_t1t1.mad/SubProcesses/P1_gg_t1t1x/matrix11.jpg
…grams.html and matrix*.jpg files (created if ghostscript is installed)
…es three jpg/html files generated if ghostscript is installed
… matrix*pdf using ps2pdf and remove matrix*ps (if ghostscript is installed)
…rix.pdf files for d in $(git ls-tree --name-only HEAD *mad/SubProcesses/P*); do git add $d/*pdf; done
… CODEGEN logs for easier merging git checkout upstream/master $(git ls-tree --name-only HEAD */CODEGEN*txt)
…tadata from matrix.pdf (Otherwise a different matrix.pdf is generated every time from the same matrix.ps)
…e PDF metadata in matrix.pdf
…remove XMP metadata from matrix.pdf
…ducible PDF and XMP metadata in matrix.pdf
… also in matrix.pdf
…rix.pdf files with reproducible PDF/XMP metadata
…m/master CODEGEN logs for easier merging git checkout upstream/master $(git ls-tree --name-only HEAD */CODEGEN*txt)
|
I have now updated this by removing pdf and xmp metadata from the matrix.pdf file to make it reproducible. This PR is now ready for approval and merging |
…raph5#850 and madgraph5#860 for xsec mismatch madgraph5#825) into susy2 Fix conflicts: epochX/cudacpp/CODEGEN/generateAndCompare.sh
|
I have updated this after merging #860 into master. @oliviermattelaer this is ready to be reviewed and merged. Thanks |
oliviermattelaer
left a comment
oliviermattelaer
left a comment
There was a problem hiding this comment.
I'm not a fan of commiting binary format in a git repo, (see xz recent issue).
But if that helps you, lets go for it!
But why not keeping both the ps and pdf? This will make more clear what is change in the pdf file if we see the change from git in the ps file (since they are text file)
…e as suggested by Olivier madgraph5#854
…ested by Olivier madgraph5#854 for d in $(git ls-tree --name-only HEAD *.mad); do git add $d/SubProcesses/P*/matrix1.ps; done
…EN logs for easier merging git checkout upstream/master $(git ls-tree --name-only HEAD */CODEGEN*txt)
Thanks Olivier :-) (What was the xz recent issue?)
Yes I have done this, good suggestion. And then if at some point we feel we must remove pdfs, we can remove them... I will merge now, thanks Andrea |
|
CI tests succeded, merging |
2 participants
Hi @oliviermattelaer this is another small PR that should be non controversial. I am just adding matrix.pdf files instead of matrix.ps files to the madgraph4gpu git repo, to make it easier to debug diagram related issues like #826.
THis does not affect CODEGEN in standard user mode. Can you please approve?
Thanks
Andrea