Skip to content

Fixing the segmentation fault detected on the haswell machine#863

Merged
roiser merged 7 commits into
master_june24from
fix_826
Jun 6, 2024
Merged

Fixing the segmentation fault detected on the haswell machine#863
roiser merged 7 commits into
master_june24from
fix_826

Conversation

@oliviermattelaer
Copy link
Copy Markdown
Member

This is a copy of the PR #852 but targetting a different master such that we can move forward waiting for Andrea.

This contains:

  1. An array (that acts a dictionary) to know which index to use in the array linking which color are valid.
  2. This includes a bunch of comment to explain the meaning of all variables
  3. This follows relatively closely (but not perfectly) the convention of Andrea

So to my point of view this can be merged swiftly.

Cheers,

Olivier

@oliviermattelaer oliviermattelaer requested a review from roiser June 5, 2024 08:43
Copy link
Copy Markdown
Member

@roiser roiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what we discussed yesterday, thanks

@roiser roiser merged commit a2a77e3 into master_june24 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants