Merged
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
referenced
this pull request
in CycloneDX/cyclonedx-python-lib
Oct 10, 2023
breaking changes
------------------
* Reworked license related models and collections
* API
* Removed class `factory.license.LicenseChoiceFactory`
The old functionality was integrated into `factory.license.LicenseFactory`.
* Method `factory.license.LicenseFactory.make_from_string()`'s parameter `name_or_spdx` was renamed to `value`
* Method `factory.license.LicenseFactory.make_from_string()`'s return value can also be a `LicenseExpression`
The behavior imitates the old `factory.license.LicenseChoiceFactory.make_from_string()`
* Renamed class `module.License` to `module.license.DisjunctliveLicense`
* Removed class `module.LicenseChoice`
Use dedicated classes `module.license.DisjunctliveLicense` and `module.license.LicenseExpression` instead
* All occurrences of `models.LicenseChoice` were replaced by `models.licenses.License`
* All occurrences of `SortedSet[LicenseChoice]` were specialized to `models.license.LicenseRepository`
fixes
------------------
* serialization of multy-licenses #365
added
------------------
* API
* Method `factory.license.LicenseFactory.make_with_expression()`
* Class `model.license.DisjunctiveLicense`
* Class `model.license.LicenseExpression`
* Class `model.license.LicenseRepository`
* Class `serialization.LicenseRepositoryHelper`
tests
------------------
* added regression test for bug #365
misc
------------------
* raised dependency `py-serializable@^9.15`
----
fixes #365
~~BLOCKED by a feature request to serializer: <https://github.com/madpah/serializable/pull/32>~~
---------
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow custom (de)normalization.
the functionality is layered over the existing (de)serialization, and falls back to it.
therefore, this is a non-breaking change.
fixes #14