Skip to content

feat: disabled handling to avoid class attributes that clash with keywords and builtins#4

Merged
madpah merged 2 commits intomainfrom
feat/allow-python-keywords
Mar 3, 2023
Merged

feat: disabled handling to avoid class attributes that clash with keywords and builtins#4
madpah merged 2 commits intomainfrom
feat/allow-python-keywords

Conversation

@madpah
Copy link
Owner

@madpah madpah commented Mar 3, 2023

After feedback from the community and early adopters, it was requested that logic that required data models to avoid attributes that clashed with Python's keywords and builtins was removed as:

  1. The clashes would never be impactful for data model properties
  2. The resulting data models look a little crappy :-)

Example: CycloneDX/cyclonedx-python-lib#290 (comment)

madpah added 2 commits March 3, 2023 08:49
…ywords` and `builtins`

Signed-off-by: Paul Horton <paul.horton@owasp.org>
Signed-off-by: Paul Horton <paul.horton@owasp.org>
@madpah madpah merged commit 2a33bc6 into main Mar 3, 2023
@madpah madpah deleted the feat/allow-python-keywords branch March 3, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant