Fix CISA.MS.AAD.1.1 to require legacy auth blocking policy scoped to all cloud apps#1651
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
Add check for conditions.applications.includeApplications containing "All" to both the $blockOther and $blockExchangeActiveSync filters in Test-MtCisaBlockLegacyAuth. Without this check, a CA policy blocking legacy auth for only specific apps (not all cloud apps) would incorrectly pass the test. Fixes #864 Agent-Logs-Url: https://github.com/maester365/maester/sessions/98fa17c8-0648-471d-8fee-2bfa6b730cc8 Co-authored-by: SamErde <20478745+SamErde@users.noreply.github.com>
Deploying maester with
|
| Latest commit: |
b177edb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://61a73dbf.maester.pages.dev |
| Branch Preview URL: | https://copilot-fix-legacy-protocols.maester.pages.dev |
Copilot
AI
changed the title
[WIP] Fix legacy protocols CA policy to check for 'all cloud apps'
Fix CISA.MS.AAD.1.1 to require legacy auth blocking policy scoped to all cloud apps
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the CISA Entra control check for MS.AAD.1.1 by ensuring Conditional Access policies that block legacy authentication are scoped to All cloud apps, preventing “partial-scope” policies (e.g., Exchange Online only) from passing while leaving other apps exposed.
Changes:
- Add
conditions.applications.includeApplications=Allrequirement to the legacy-auth blocking policy filters. - Refine the failing result message to explicitly call out “for all cloud apps”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test-MtCisaBlockLegacyAuthwas not checking that the CA policy's resource scope includes "All" cloud apps. A policy blocking legacy auth for only specific apps (e.g., Exchange Online only) would pass the test, leaving legacy auth open on other cloud apps.Added
conditions.applications.includeApplications -contains "All"to both the$blockOtherand$blockExchangeActiveSyncfilters — consistent with how the sibling Maester tests (Test-MtCaBlockLegacyOtherAuthentication,Test-MtCaBlockLegacyExchangeActiveSyncAuthentication) already check this.Contribution Checklist
Before submitting this PR, please confirm you have completed the following:
/powershell/tests/pester.ps1on your local system.Join us at the Maester repository discussions 💬 or Entra Discord 🧑💻 for more help and conversations!