Barcode detector and barcode dictionary is a bit messy regarding the code and difficult to debug. In addition, BarcodeDetector have no tests at all, and to pinpoint errors we should use an integration test for the tools. We should refactor and add tests for the following:
Barcode detector and barcode dictionary is a bit messy regarding the code and difficult to debug. In addition,
BarcodeDetectorhave no tests at all, and to pinpoint errors we should use an integration test for the tools. We should refactor and add tests for the following:BarcodeDictionaryshould be refactored and cleaned. Methods names are confusing and some of then are not used at all.BarcodeDictionaryTestrefactoring (it still have the structure of Junit). It should be more exhaustive in the test paths.BarcodeDictionaryFactoryshould disappear in favor of an static method inEdited: we should convert to a proper factory/builder, adding options such as create from SAM header file (BarcodeDictionaryto construct from a file.@RG), or allowing patterns for ID generation and other tags in SAM-header.BarcodeDetector.BarcodeDetector. Current contracts and implementations are a mess and very difficult to debug. Requires tests for checking that nothing is broken. Edited: also should create with a builder to add different features for detection and make a smooth transition to the new classes/implemenations.