fix(HappyHare): fix EMU logo in dark mode#2369
Merged
meteyou merged 1 commit intomainsail-crew:developfrom Jan 3, 2026
Merged
Conversation
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the EMU logo appearance in dark mode by implementing a theme-aware icon system. The EMU logo now displays with better contrast in dark mode while maintaining the original appearance in light mode.
- Adds a dark mode variant of the EMU logo (
mmuIconEmuDark) - Implements a theme-aware icon mapping system (
mmuThemeIcons) - Refactors the logo getter to switch between theme-specific icons based on the current Vuetify theme
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/plugins/mmuIcons.ts | Adds the dark mode EMU logo icon path and introduces a theme icon mapping structure |
| src/components/panels/Mmu/MmuUnitFooter.vue | Refactors the logo getter to support theme-specific icons with automatic fallback to base icons |
mryel00
approved these changes
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a function to have different icon logos for dark/light mode. For example the EMU logo looks "wrong" in dark mode, so we (@DW-Tas and I) added an inverted icon here.
Related Tickets & Documents
none
Mobile & Desktop Screenshots/Recordings
Dark mode before:
Dark mode with this PR:
Light mode before and now (nothing changed here):
[optional] Are there any post-deployment tasks we need to perform?
none