refactor(Dialogs): Modernize with VModel and consolidate buttons#2372
Merged
meteyou merged 57 commits intomainsail-crew:developfrom Jan 7, 2026
Merged
refactor(Dialogs): Modernize with VModel and consolidate buttons#2372meteyou merged 57 commits intomainsail-crew:developfrom
meteyou merged 57 commits intomainsail-crew:developfrom
Conversation
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
… VModel Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
…el and refactor onShowDialogChanged Signed-off-by: Stefan Dej <meteyou@gmail.com>
…odel Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
…nfirmationDialog Signed-off-by: Stefan Dej <meteyou@gmail.com>
…l and focus into the input after opening Signed-off-by: Stefan Dej <meteyou@gmail.com>
…us into the input after opening Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
…p confirmation Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
…firmationDialog Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
…way binding Signed-off-by: Stefan Dej <meteyou@gmail.com>
…g using v-model Signed-off-by: Stefan Dej <meteyou@gmail.com>
…dialog using v-model Signed-off-by: Stefan Dej <meteyou@gmail.com>
…tion dialog using v-model Signed-off-by: Stefan Dej <meteyou@gmail.com>
…el for showDialog Signed-off-by: Stefan Dej <meteyou@gmail.com>
…nfirmation dialog using v-model Signed-off-by: Stefan Dej <meteyou@gmail.com>
…sibility Signed-off-by: Stefan Dej <meteyou@gmail.com>
…r device change Signed-off-by: Stefan Dej <meteyou@gmail.com>
…te actions in ConfigFilesPanel.vue Signed-off-by: Stefan Dej <meteyou@gmail.com>
…deObject.vue Signed-off-by: Stefan Dej <meteyou@gmail.com>
…r.vue Signed-off-by: Stefan Dej <meteyou@gmail.com>
…apseFilesPanel.vue Signed-off-by: Stefan Dej <meteyou@gmail.com>
…ce across dialog components Signed-off-by: Stefan Dej <meteyou@gmail.com>
…og components Signed-off-by: Stefan Dej <meteyou@gmail.com>
…espace across dialog components Signed-off-by: Stefan Dej <meteyou@gmail.com>
…ther locations Signed-off-by: Stefan Dej <meteyou@gmail.com>
…ther locations Signed-off-by: Stefan Dej <meteyou@gmail.com>
…ross various components Signed-off-by: Stefan Dej <meteyou@gmail.com>
…nent Signed-off-by: Stefan Dej <meteyou@gmail.com>
…mationDialog Signed-off-by: Stefan Dej <meteyou@gmail.com>
meteyou
changed the title
…rmation dialog Signed-off-by: Stefan Dej <meteyou@gmail.com>
mryel00
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modernizes the dialog system across the codebase by standardizing patterns and consolidating duplicate code.
1. Dialog VModel Migration
@Prop+@Emitpattern to@VModelfor cleaner two-way binding2. ConfirmationDialog Consolidation
ConfirmationDialogwith optionaliconandactionButtonColorpropsConfirmationDialog:CancelJobDialogCoolDownDialogHeightmapRemoveProfileDialogGcodefilesDeleteFileDialogGcodefilesDeleteDirectoryDialogGcodefilesDeleteSelectedFilesDialogHistoryDeleteJobDialogHistoryDeleteSelectedJobsDialogHistoryListPanelDeleteSelectedJobsDialogHistoryDetailsDialogEntrySpoolmanEjectSpoolDialog3. Button Label Consolidation
Buttons.Close,Buttons.Save,Buttons.CancelnamespaceButtons.*keysRelated Tickets & Documents
none
Mobile & Desktop Screenshots/Recordings
none
[optional] Are there any post-deployment tasks we need to perform?
none