refactor: move HistoryListPanelCol interface to centralized type#2379
Merged
meteyou merged 2 commits intomainsail-crew:developfrom Jan 7, 2026
Merged
Conversation
…ving computed property Signed-off-by: Stefan Dej <meteyou@gmail.com>
…ol to use centralized types Signed-off-by: Stefan Dej <meteyou@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the TypeScript codebase by moving the HistoryListPanelCol interface from a component file to a centralized types file, fixing TypeScript import errors (TS2614). It also simplifies the HistoryListEntryMaintenance.vue component by removing an unnecessary computed property.
- Moved
HistoryListPanelColinterface fromHistoryListPanel.vueto@/store/server/history/types.ts - Updated all imports across 4 files to reference the new centralized location
- Removed unnecessary
cssClassescomputed property inHistoryListEntryMaintenance.vue, replacing it with a direct class binding
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/store/server/history/types.ts | Added HistoryListPanelCol interface definition to centralized types file |
| src/components/panels/HistoryListPanel.vue | Removed local interface definition and updated import to use centralized type |
| src/components/panels/History/HistoryListPanelExportCsv.vue | Updated import statement to reference centralized type location |
| src/components/panels/History/HistoryListEntryMaintenance.vue | Updated import and removed unnecessary cssClasses computed property, replacing with direct class binding |
| src/components/panels/History/HistoryListEntryJob.vue | Updated import statement to reference centralized type location |
mryel00
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the HistoryListPanelCol interface from HistoryListPanel.vue to @/store/server/history/types.ts to fix TypeScript import errors (TS2614). Additionally, it removes an unnecessary computed property in HistoryListEntryMaintenance.vue.
Related Tickets & Documents
n/a
Mobile & Desktop Screenshots/Recordings
n/a (no visual changes)