smartcontract/cli,client: drop activator-only pollers and Rejected branches#3700
Open
elitegreg wants to merge 1 commit into
Conversation
…anches - poll_for_activation drops poll_for_user_activated and poll_for_multicastgroup_activated; both watched activator-driven transitions that no longer happen post-RFC-11 (creates are atomic to Activated). - poll_for_device_activated and poll_for_link_activated drop the Rejected status arm — also activator-driven. - CLI --wait callers (user create/create-subscribe/subscribe, multicastgroup create/update) and client/doublezero connect swap the polling step for a single get-with-retry that only rides out RPC lag. - CHANGELOG entry under Unreleased. The SDK command structs that still expose use_onchain_(de)allocation fields are intentionally untouched — those activate/deactivate/remove/ closeaccount commands are scheduled for wholesale removal. Phase 4, PR 4.2 of the activator-removal effort. Refs #3607, closes #3614.
elitegreg
force-pushed
the
gm/3614-rust-sdk-cli-drop-onchainallocation-flag-gated-code
branch
from
4209059 to
9ff501d
Compare
elitegreg
changed the title
martinsander00
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
poll_for_user_activatedandpoll_for_multicastgroup_activatedfromcli/src/poll_for_activation.rs; both watched activator-driven transitions that no longer happen post-RFC-11 (creates are atomic toActivated).Rejectedstatus arm frompoll_for_device_activatedandpoll_for_link_activated— also activator-driven.--waitcallers (user create/create-subscribe/subscribe,multicastgroup create/update) andclient/doublezeroconnectswap the polling step for a single get-with-retry that only rides out RPC lag.The SDK command structs that still expose
use_onchain_(de)allocationfields (user::activate/closeaccount,link::activate/closeaccount,multicastgroup::activate/deactivate,device::interface::activate/remove) are intentionally untouched — those activate/deactivate/remove/closeaccount commands are scheduled for wholesale removal in a follow-up.Phase 4, PR 4.2 of the activator-removal effort. Refs #3607, closes #3614.
Testing Verification
poll_for_user_activatedin connect.rs across the IBRL, multicast-publisher, multicast-subscriber, and edge connect flows).