SQL assignment 1 finished#1
Open
manntintin wants to merge 1 commit into
Open
Conversation
Owner
Author
|
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
l-mack
suggested changes
Apr 22, 2025
l-mack
left a comment
l-mack
left a comment
There was a problem hiding this comment.
Please review the feedback on your assignment below. Based on the comments provided, please revise and resubmit the indicated questions:
- Logical Model: Please ensure the columns for which the relationship exists are indicated clearly and the direction of the relationship is is correct.
l-mack
approved these changes
Apr 24, 2025
l-mack
left a comment
l-mack
left a comment
There was a problem hiding this comment.
Great work! 29/30
Some general feedback:
- Your logical model is great, it contains table names, column names, relationship-type, it just lacks a clear relationships between columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist